`","2024-08-21T10:29:21Z","https://github.com/Tresjs/tres/issues/418",0.72534955,{"description":2885,"labels":2886,"number":2887,"owner":2877,"repository":2888,"state":2879,"title":2889,"updated_at":2890,"url":2891,"score":2892},"### Describe the bug\r\n\r\nI am import `OrbitControls` by using TypeScript, but the typedef of `OrbitControls` is any\r\n\r\n```ts\r\nimport { OrbitControls } from '@tresjs/cientos'\r\n\r\ntype ComponentInstance = InstanceType\u003Ctypeof OrbitControls>\r\ntype ControlsInstance = ComponentInstance['instance']\r\n// ^? This is any\r\n```\r\n\r\nI found the build source doesn't include the file `OrbitControls.vue.d.ts`.\r\n\r\n\r\n\r\n\r\n### Reproduction\r\n\r\nhttps://stackblitz.com/edit/tresjs-basic-grkvtv?file=package.json,src%2Fmain.ts\r\n\r\n### Steps to reproduce\r\n\r\nOpen `main.ts`, then check `ControlsInstance`'s typedef.\r\n\r\n### System Info\r\n\r\n```shell\r\n@tresjs/cientos is v4.0.3\r\n```\r\n\r\n\r\n### Used Package Manager\r\n\r\npnpm\r\n\r\n### Code of Conduct\r\n\r\n- [X] I agree to follow this project's [Code of Conduct](https://github.com/Tresjs/cientos/blob/main/CODE_OF_CONDUCT.md)\r\n- [X] Read the [Contributing Guidelines](https://github.com/Tresjs/cientos/blob/main/CONTRIBUTING.md).\r\n- [X] Read the [docs](https://cientos.tresjs.org/guide).\r\n- [X] Check that there isn't [already an issue](https://github.com/Tresjs/cientos/issues) that reports the same bug to avoid creating a duplicate.\r\n- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.",[],520,"cientos","Miss typedef for CameraControls/MapControls/OrbitControls","2024-11-08T03:20:44Z","https://github.com/Tresjs/cientos/issues/520",0.7375352,{"description":2894,"labels":2895,"number":2902,"owner":2877,"repository":2878,"state":2879,"title":2903,"updated_at":2904,"url":2905,"score":2906},"I noticed that Tres set the DPR ([see code](https://github.com/Tresjs/tres/blob/00bef337f189b04ee3b77a4ce0afea63ce2973b2/src/composables/useRenderer/index.ts#L152C26-L152C45)) completely in autonomy without any way to control that, imho is conceptually wrong for couple of reasons:\r\n\r\n1. The dev should be in charge to decide the DPR or **at least be able to clamp**. For example if the app is opened on a 3DPR mobile is gonna run at 3, that is completely insane.\r\n2. The app should not change the dpr on resize without consent. I noticed it because i was setting manually in a range \r\n ```js \r\n const dpr = MathUtils.clamp(window.devicePixelRatio, 1, 1.4) \r\n renderer.value.setPixelRatio(dpr)\r\n ```\r\n but on resize switching between monitors on my macbook was set back to 2 due the `useDevicePixelRatio` hook. This second point tho depends on the first one. If We decide to let the app handle the resize, **it's 100% needed** to add a `clamp` on that.\r\n \r\nThis can lead to some big issues, both perf wise and effect wise. I notice the \"issue\" because i was doing some effect in screen-space, where my resolution wasn't matching my DPR `vec2 st = gl_FragCoord.xy / (gResolution * gDpr);` \r\n \r\n My take on this is that the library can take care of the DPR but at least give the user some way to control, like they don in `r3f` where you can set `dpr=[low, high]` that clamps it :)\r\n \r\n \r\n\r\n### Reproduction\r\n\r\n---\r\n\r\n### Steps to reproduce\r\n\r\n----\r\n\r\n### System Info\r\n\r\n```shell\r\n----\r\n```\r\n\r\n\r\n### Used Package Manager\r\n\r\nnpm\r\n\r\n### Code of Conduct\r\n\r\n- [X] I agree to follow this project's [Code of Conduct](https://github.com/Tresjs/tres/blob/main/CODE_OF_CONDUCT.md)\r\n- [X] Read the [Contributing Guidelines](https://github.com/Tresjs/tres/blob/main/CONTRIBUTING.md).\r\n- [X] Read the [docs](https://tresjs.org/guide).\r\n- [X] Check that there isn't [already an issue](https://github.com/tresjs/tres/issues) that reports the same bug to avoid creating a duplicate.\r\n- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.",[2896,2899],{"name":2897,"color":2898},"feature","c2e0c6",{"name":2900,"color":2901},"p2-to-be-discussed","97C1B1",765,"Library override the DPR setting in autonomy without chances to clamp / control it","2024-08-01T15:59:05Z","https://github.com/Tresjs/tres/issues/765",0.7710033,{"description":2908,"labels":2909,"number":2910,"owner":2877,"repository":2878,"state":2911,"title":2912,"updated_at":2913,"url":2914,"score":2915},"### Describe the bug\r\n\r\nOne receives an empty string in the component if a prop is set without an explicit value (like `\u003CTresCanvas disable-render>`). \r\nBoolean props have the value false instead of undefined by default even if no default is set. I noticed this behavior in EffectComposer.\r\n\r\n### Reproduction\r\n\r\nhttps://stackblitz.com/edit/tresjs-basic-rwhajn?file=src%2Fcomponents%2FTheExperience.vue\r\n\r\n### Steps to reproduce\r\n\r\nUse a Tres component with a boolean prop without setting it explicitly and check the value inside of the component.\r\n\r\n### System Info\r\n\r\n_No response_\r\n\r\n### Used Package Manager\r\n\r\npnpm\r\n\r\n### Code of Conduct\r\n\r\n- [X] I agree to follow this project's [Code of Conduct](https://github.com/Tresjs/tres/blob/main/CODE_OF_CONDUCT.md)\r\n- [X] Read the [Contributing Guidelines](https://github.com/Tresjs/tres/blob/main/CONTRIBUTING.md).\r\n- [X] Read the [docs](https://tresjs.org/guide).\r\n- [X] Check that there isn't [already an issue](https://github.com/tresjs/tres/issues) that reports the same bug to avoid creating a duplicate.\r\n- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.",[],325,"closed","Boolean props have wrong default value","2023-09-05T13:29:30Z","https://github.com/Tresjs/tres/issues/325",0.7425003,{"description":2917,"labels":2918,"number":104,"owner":2877,"repository":2888,"state":2911,"title":2925,"updated_at":2926,"url":2927,"score":2928},"**Is your feature request related to a problem? Please describe.**\r\n`packages/cientos/core/OrbitControls.vue` offers limited props\r\n\r\n```ts\r\nexport interface OrbitControlsProps {\r\n /**\r\n * Whether to make this the default controls.\r\n *\r\n * @default false\r\n * @type {boolean}\r\n * @memberof OrbitControlsProps\r\n * @see https://threejs.org/docs/#examples/en/controls/OrbitControls\r\n */\r\n makeDefault?: boolean\r\n /**\r\n * The camera to control.\r\n *\r\n * @type {Camera}\r\n * @memberof OrbitControlsProps\r\n * @see https://threejs.org/docs/#examples/en/controls/OrbitControls\r\n */\r\n camera?: Camera\r\n /**\r\n * The dom element to listen to.\r\n *\r\n * @type {HTMLElement}\r\n * @memberof OrbitControlsProps\r\n * @see https://threejs.org/docs/#examples/en/controls/OrbitControls\r\n */\r\n domElement?: HTMLElement\r\n /**\r\n * The target to orbit around.\r\n *\r\n * @type {Ref\u003CVector3>}\r\n * @memberof OrbitControlsProps\r\n * @see https://threejs.org/docs/#examples/en/controls/OrbitControls\r\n */\r\n target?: Ref\u003CVector3>\r\n /**\r\n * Whether to enable damping.\r\n *\r\n * @default false\r\n * @type {boolean}\r\n * @memberof OrbitControlsProps\r\n * @see https://threejs.org/docs/#examples/en/controls/OrbitControls\r\n */\r\n enableDamping?: boolean\r\n}\r\n```\r\n\r\n\r\n**Describe the solution you'd like**\r\nThe ThreeJS [OrbitControls](https://threejs.org/docs/#examples/en/controls/OrbitControls) has way more features and properties we could support\r\n\r\n**Suggested solution**\r\nAdd rest of the properties to abstraction\r\n\r\n**Additional context**\r\nAdd any other context or screenshots about the feature request here.\r\n",[2919,2922],{"name":2920,"color":2921},"good first issue","7057ff",{"name":2923,"color":2924},"help wanted","008672","Enhance OrbitControls cientos abstraction","2023-05-18T13:44:09Z","https://github.com/Tresjs/cientos/issues/3",0.7456567,{"description":2930,"labels":2931,"number":104,"owner":2877,"repository":2932,"state":2911,"title":2933,"updated_at":2934,"url":2935,"score":2928},"```Vue\r\n\u003CTresCanvas clear-color=\"#000000\">\r\n \u003CTresPerspectiveCamera\r\n :position=\"[0, 0, 5000]\"\r\n :fov=\"50\"\r\n :aspect=\"1\"\r\n :near=\"1\"\r\n :far=\"10000\"\r\n />\r\n \u003CTresScene>\r\n \u003CTresPoints>\r\n \u003CTresBufferGeometry :position=\"[vertices, 3]\" />\r\n \u003CTresPointsMaterial :color=\"0x888888\" />\r\n \u003C/TresPoints>\r\n \u003C/TresScene>\r\n\u003C/TresCanvas>\r\n```\r\nNo matter how i change `aspect`, for exampe **0.5** or **2**, there is no change in view.\r\n\r\naspect = 0.5\r\n\u003Cimg width=\"656\" alt=\"image\" src=\"https://user-images.githubusercontent.com/11868294/219375921-50474cdc-39bf-4248-bca7-1dd2ee6fe873.png\">\r\n\r\n\r\naspect = 1\r\n\u003Cimg width=\"582\" alt=\"image\" src=\"https://user-images.githubusercontent.com/11868294/219375756-00dc3849-7ec3-4428-bd6c-5ebdb00d8381.png\">\r\n\r\n\r\n\r\n\r\n\r\naspect = 2\r\n\u003Cimg width=\"634\" alt=\"image\" src=\"https://user-images.githubusercontent.com/11868294/219375639-72380307-a3f5-455f-8d7a-ef44a0e880cd.png\">\r\n\r\nMaybe i miss something?\r\n\r\n\r\n",[],"lab","TresPerspectiveCamera: aspect not work?","2023-08-26T15:28:15Z","https://github.com/Tresjs/lab/issues/3",{"description":2937,"labels":2938,"number":2939,"owner":2877,"repository":2940,"state":2911,"title":2941,"updated_at":2942,"url":2943,"score":2944},"### Describe the bug\n\nI added OrbitControls, and when scrolling I get the following error\r\n\r\n```\r\nWARNING: OrbitControls.js encountered an unknown camera type - dolly/zoom disabled.\r\n```\r\n\r\nMake it impossible to scroll to zoom in/out. \r\n\r\n\r\n\n\n### Reproduction\n\nhttps://stackblitz.com/edit/nuxt-starter-3nnslu?file=package.json\n\n### Steps to reproduce\n\n_No response_\n\n### System Info\n\n```shell\nSee https://stackblitz.com/edit/nuxt-starter-3nnslu?file=package.json\n```\n\n\n### Used Package Manager\n\nnpm\n\n### Code of Conduct\n\n- [X] I agree to follow this project's [Code of Conduct](https://github.com/Tresjs/tres/blob/main/CODE_OF_CONDUCT.md)\n- [X] Read the [Contributing Guidelines](https://github.com/Tresjs/tres/blob/main/CONTRIBUTING.md).\n- [X] Read the [docs](https://tresjs.org/guide).\n- [X] Check that there isn't [already an issue](https://github.com/tresjs/tres/issues) that reports the same bug to avoid creating a duplicate.\n- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.",[],49,"nuxt","Nuxtjs: OrbitControls.js encountered an unknown camera type","2023-11-08T09:28:32Z","https://github.com/Tresjs/nuxt/issues/49",0.75627303,{"description":2946,"labels":2947,"number":2949,"owner":2877,"repository":2940,"state":2911,"title":2950,"updated_at":2951,"url":2952,"score":2953},"### Describe the bug\n\n\r\n\n\n### Reproduction\n\nplayground\n\n### Steps to reproduce\n\nRun `npm install` and then `npm run dev` or `npm run build & npm run preview`\n\n### System Info\n\n```shell\nSystem:\r\n OS: macOS 13.5.1\r\n CPU: (8) arm64 Apple M1 Pro\r\n Memory: 97.73 MB / 16.00 GB\r\n Shell: 5.9 - /bin/zsh\r\n Binaries:\r\n Node: 18.14.1 - ~/.nvm/versions/node/v18.14.1/bin/node\r\n Yarn: 1.22.19 - /usr/local/bin/yarn\r\n npm: 9.3.1 - ~/.nvm/versions/node/v18.14.1/bin/npm\r\n Browsers:\r\n Brave Browser: 117.1.58.135\r\n Chrome: 117.0.5938.149\r\n Firefox: 118.0.1\r\n Safari: 16.6\r\n```\n```\n\n\n### Used Package Manager\n\npnpm\n\n### Code of Conduct\n\n- [X] I agree to follow this project's [Code of Conduct](https://github.com/Tresjs/tres/blob/main/CODE_OF_CONDUCT.md)\n- [X] Read the [Contributing Guidelines](https://github.com/Tresjs/tres/blob/main/CONTRIBUTING.md).\n- [X] Read the [docs](https://tresjs.org/guide).\n- [X] Check that there isn't [already an issue](https://github.com/tresjs/tres/issues) that reports the same bug to avoid creating a duplicate.\n- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.",[2948],{"name":2868,"color":2869},46,"Multiple Instances of ThreeJS - Orbitcontrols broken","2023-10-06T03:55:26Z","https://github.com/Tresjs/nuxt/issues/46",0.7571892,{"description":2955,"labels":2956,"number":2959,"owner":2877,"repository":2878,"state":2911,"title":2960,"updated_at":2961,"url":2962,"score":2963},"**Describe the bug**\r\nWhen using any of the loops from renderLoops composable, `delta = clock.getDelta()` is always 0, it can't be used for animation\r\n\r\n\r\n**Reproduction**\r\n[Reproduction Link\r\n](https://stackblitz.com/edit/tresjs-basic-animations?file=src%2Fcomponents%2FTheExperience.vue)\r\n\r\n**Steps**\r\nSteps to reproduce the behavior:\r\n1. Go to 'TheExperience.vue`\r\n2. Check the `onLoop`composable callback\r\n3. Console delta\r\n4. See value\r\n\r\n**Expected behavior**\r\nDelta should be the seconds passed since the time [.oldTime](https://threejs.org/docs/index.html#api/en/core/Clock.oldTime) was set and sets [.oldTime](https://threejs.org/docs/index.html#api/en/core/Clock.oldTime) to the current time.\r\nIf [.autoStart](https://threejs.org/docs/index.html#api/en/core/Clock.autoStart) is true and the clock is not running, also starts the clock\r\n\r\n**Screenshots**\r\nIf applicable, add screenshots to help explain your problem.\r\n\r\n**System Info**\r\nOutput of `npx envinfo --system --npmPackages '{vite,@tresjs/*, three, vue}' --binaries --browsers` \r\n\r\n```\r\n System:\r\n OS: Linux 5.0 undefined\r\n CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz\r\n Memory: 0 Bytes / 0 Bytes\r\n Shell: 1.0 - /bin/jsh\r\n Binaries:\r\n Node: 16.14.2 - /usr/local/bin/node\r\n Yarn: 1.22.19 - /usr/local/bin/yarn\r\n npm: 7.17.0 - /usr/local/bin/npm\r\n npmPackages:\r\n @tresjs/cientos: ^1.0.0 => 1.0.0 \r\n @tresjs/core: ^1.1.0 => 1.1.0 \r\n vite: ^3.2.4 => 3.2.4 \r\n```\r\n",[2957,2958],{"name":2868,"color":2869},{"name":2923,"color":2924},81,"onLoop delta is always 0","2023-01-17T09:16:52Z","https://github.com/Tresjs/tres/issues/81",0.75801915,{"description":2965,"labels":2966,"number":2970,"owner":2877,"repository":2878,"state":2911,"title":2971,"updated_at":2972,"url":2973,"score":2974},"**Describe the bug**\r\nThe following props are not being properly updated:\r\n\r\n- `enabled`.\r\n- `showX`, `showY`, `showZ`\r\n- `axis`.\r\n\r\n**Reproduction**\r\n[Stackblitz](https://stackblitz.com/edit/tresjs-transform-controls?file=src%2Fcomponents%2FTheExperience.vue,package.json) \r\n\r\n**Steps**\r\nSteps to reproduce the behavior:\r\n1. Go to[ '...'](https://stackblitz.com/edit/tresjs-transform-controls?file=src%2Fcomponents%2FTheExperience.vue,package.json)\r\n2. Play with props on the panel top right\r\n\r\n**Expected behavior**\r\nAll props work\r\n\r\n\r\n**System Info**\r\nOutput of `npx envinfo --system --npmPackages '{vite,@tresjs/*, three, vue}' --binaries --browsers` \r\n\r\n```\r\n System:\r\n OS: Linux 5.0 undefined\r\n CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz\r\n Memory: 0 Bytes / 0 Bytes\r\n Shell: 1.0 - /bin/jsh\r\n Binaries:\r\n Node: 16.14.2 - /usr/local/bin/node\r\n Yarn: 1.22.19 - /usr/local/bin/yarn\r\n npm: 7.17.0 - /usr/local/bin/npm\r\n npmPackages:\r\n @tresjs/cientos: ^1.3.0 => 1.3.0 \r\n @tresjs/core: ^1.4.0 => 1.4.0 \r\n vite: ^3.2.4 => 3.2.4 \r\n```\r\n\r\n**Additional context**\r\nMost probably is because this properties doesn't use a `set` function\r\n",[2967,2968,2969],{"name":2868,"color":2869},{"name":2920,"color":2921},{"name":2923,"color":2924},63,"TransformControls cientos props without set method not updating","2023-01-07T18:45:57Z","https://github.com/Tresjs/tres/issues/63",0.7597447,["Reactive",2976],{},["Set"],["ShallowReactive",2979],{"$fTRc1wZytZ_XrK4EfJfei_Sz-An4H4Yy6syhVxH_PVJc":-1,"$f6UpF9pNEcOk0mpDQqrvn3JylCc33cbxvGgUyCoySpeA":-1},"/Tresjs/cientos/447"]